Skip to content

Initial batch of changes to enable bundling of the extension - #3384

Merged
Don Jayamanne (DonJayamanne) merged 27 commits into
microsoft:masterfrom
DonJayamanne:issue3021BundleExtSrcc
Nov 20, 2018
Merged

Initial batch of changes to enable bundling of the extension#3384
Don Jayamanne (DonJayamanne) merged 27 commits into
microsoft:masterfrom
DonJayamanne:issue3021BundleExtSrcc

Conversation

@DonJayamanne

@DonJayamanne Don Jayamanne (DonJayamanne) commented Nov 16, 2018

Copy link
Copy Markdown

For #3021

  • Pull request represents a single change (i.e. not fixing disparate/unrelated things in a single PR)
  • Title summarizes what is changing
  • [no] Has a news entry file (remember to thank yourself!)
  • [no] Unit tests & system/integration tests are added/updated
  • [no] Test plan is updated as appropriate
  • package-lock.json has been regenerated by running npm install (if dependencies have changed)

brettcannon
Brett Cannon (brettcannon) approved these changes Nov 19, 2018
View reviewed changes
Comment thread build/webpack/webpack.datascience-ui.config.ts Outdated
Comment thread build/webpack/webpack.extension.config.ts Outdated
Comment thread build/webpack/webpack.extension.config.ts Outdated
Comment thread webpack.config.js Outdated
d3r3kk
Derek Keeler (d3r3kk) approved these changes Nov 20, 2018
View reviewed changes

@d3r3kk Derek Keeler (d3r3kk) left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Can't wait to see it in action!

@DonJayamanne

Don Jayamanne (DonJayamanne) commented Nov 20, 2018 •
edited
Loading

Copy link
Copy Markdown
Author

Looks good. Can't wait to see it in action!

Won't, until I get the YAML stuff in.
Cuz the CI and CD pipelines need to change.

  • The commands used to compile and build the extension
  • Subsequently commands used to upload
    • Cuz after all tests pass, we need to bundle using webpack
    • Run smoke tests
    • Finally upload this webpack bundled version to azure blob store
    • I.e. totally new process

@DonJayamanne
Don Jayamanne (DonJayamanne) merged commit d987489 into microsoft:master Nov 20, 2018
@DonJayamanne
Don Jayamanne (DonJayamanne) deleted the issue3021BundleExtSrcc branch December 14, 2018 22:07
@lock lock Bot locked as resolved and limited conversation to collaborators Jul 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@brettcannon Brett Cannon (brettcannon) brettcannon approved these changes
+1 more reviewer
@d3r3kk Derek Keeler (d3r3kk) d3r3kk approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@DonJayamanne @brettcannon @d3r3kk